Repository navigation
Fix edgecolor being only applied to first bar. - #9353
Conversation
afvincent
left a comment
There was a problem hiding this comment.
Looks fine to me. (I guess that ideally one might want to add some test 😈).
|
Actually I am thinking to add some machinery to add "as if" comparison tests, which generate two figures and checks that they are indeed identical (in this case, we would be comparing |
|
Well that sounds indeed cleverer that the genuine image test I was going to write... Looking quickly at |
|
You can already write this "by hand" (https://github.com/matplotlib/matplotlib/pull/9305/files#diff-663c17d0729218d60dbb862c286a17d4R5327), but ideally the machinery should be such that |
|
For this the simplest test is to pass a scalar and then just iterate over the returned artists and check the edge color is what you expect. |
fc3e07c to
7ff9287
Compare
|
tests in |
Backport PR #9353 on branch v2.1.x
closes #9351
PR Summary
PR Checklist