Skip to content

Fix poorly done deprecations in image.py. - #9335

Merged
tacaswell merged 3 commits into
matplotlib:masterfrom
anntzer:figureoptions-fix
Oct 10, 2017
Merged

tacaswell merged 3 commits into
matplotlib:masterfrom
anntzer:figureoptions-fix

Conversation

@anntzer

@anntzer anntzer commented Oct 9, 2017

Copy link
Copy Markdown
Contributor

xref #9332.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Oct 9, 2017
@tacaswell tacaswell added this to the 2.1.1 (next bug fix release) milestone Oct 9, 2017
@tacaswell

Copy link
Copy Markdown
Member

took the liberty of adding a test.

@WeatherGod

Copy link
Copy Markdown
Member

Is the appveyor failure the same as the one that has been happening?

Comment thread lib/matplotlib/image.py Outdated
return {v: k for k, v in six.iteritems(_interpd_)}

@property
@cbook.deprecated("2.1")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this deprecation tell us what to use instead?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@tacaswell
tacaswell merged commit ad730d1 into matplotlib:master Oct 10, 2017
@anntzer
anntzer deleted the figureoptions-fix branch October 10, 2017 23:11
tacaswell added a commit that referenced this pull request Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants