Repository navigation
Throw std::runtime_exception instead of char*. - #9289
Merged
Merged
Conversation
This should make it easier to debug exceptions falling out of the C++ code, as the C++ runtime will print the error message (the `what()` of the exception) on its way to aborting the program. Did a regex replace; removed the `char*` handler in CALL_CPP_FULL; and remove a bunch of extra whitespace.
Member
|
Would prefer @mdboom or @ianthomas23 sign off on this before merging. |
ianthomas23
approved these changes
Oct 6, 2017
ianthomas23
left a comment
Member
There was a problem hiding this comment.
I'm happy with this.
Don't understand the AppVeyor failure.
Member
Member
|
Hm. |
Contributor
Author
|
Oops. New PR coming. |
6 tasks
QuLogic
added a commit
that referenced
this pull request
Oct 6, 2017
Backport PR #9289 on branch v2.1.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should make it easier to debug exceptions falling out of the C++
code, as the C++ runtime will print the error message (the
what()ofthe exception) on its way to aborting the program.
Did a regex replace; removed the
char*handler in CALL_CPP_FULL; andremove a bunch of extra whitespace.
For example, before application of the patch in #9074, the failing code now gives
Should also help with #9244.
PR Summary
PR Checklist