Skip to content

Re-organize What's new page - #9260

Merged
tacaswell merged 49 commits into
matplotlib:v2.1.xfrom
QuLogic:whatsnew-plots
Oct 7, 2017
Merged

tacaswell merged 49 commits into
matplotlib:v2.1.xfrom
QuLogic:whatsnew-plots

Conversation

@QuLogic

@QuLogic QuLogic commented Oct 2, 2017

Copy link
Copy Markdown
Member

Add more plots and fix some remaining issues from #9259.

@QuLogic QuLogic added this to the 2.1 (next point release) milestone Oct 2, 2017
@QuLogic
QuLogic requested a review from tacaswell October 2, 2017 04:27
@tacaswell

Copy link
Copy Markdown
Member

My rebase is completely un-doable (it organizes the sections), can I just push commits to this branch?

@QuLogic

QuLogic commented Oct 2, 2017

Copy link
Copy Markdown
Member Author

Sure, go ahead.

Comment thread doc/users/whats_new.rst Outdated
unit. The default string is " ", which preserves the former
behavior. Additionally, the separator is now present between the value
and its unit even in the absence of SI prefix. There was formerly a
bug that was causing strings like "3.14V" to be returned instead of

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding bq's here and below will probably help making the difference (extra space) more visible

Comment thread doc/users/whats_new.rst Outdated
abstract base class.

Validation of line style rcParams
---------------------------------

@anntzer anntzer Oct 5, 2017 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just below, at "strings like ...": would add regular quotes (within the bq's) around "dashed" and "--"

I would lift the subsubsub... headings one level up (perhaps slight rewording) and just drop the "Validation of line style params".

Comment thread doc/users/whats_new.rst
pytest
------

The automated tests have been switched from `nose` to `pytest`.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps link to the respective projects

@anntzer

anntzer commented Oct 5, 2017 •

Copy link
Copy Markdown
Contributor

the entry about Renderer._uid in the API changes should be removed (killed by #9070)

@tacaswell

Copy link
Copy Markdown
Member

@QuLogic @anntzer I think this is ready for another round.

@QuLogic QuLogic left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly minor stuff; I can't switch branches at the moment or I would just push the changes.

Comment thread doc/api/api_changes.rst Outdated
All functionallity from `mpl_toolkits.axes_grid` can be found in
either `mpl_toolkits.axes_grid1` or `mpl_toolkits.axisartist`. Axes
classes from `mpl_toolkits.axes_grid` based on `Axis` from
`mpl_toolkits.axisartist` can be found in `mpl_toolkits.axisartist`

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the first one be axes_grid? (Plus add period at end).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functionallity (typo: double l)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the typo.

I think that this sentence is correct, the Axes sub-classes that used be axis_grid used tools from axisartist, those are now in axisartist

Comment thread doc/api/api_changes.rst Outdated
barh(bottom, width, *, align='center', **kwargs)

despite behaving as the center in both cases. The methods now take ``*args, **kwargs``
is input and are documented to have the primary signatures of::

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/is/as/

Comment thread doc/api/api_changes.rst Outdated
requests that a Delaunay triangulation is calculated, which includes
`matplotlib.pyplot.tricontour`, `matplotlib.pyplot.tricontourf`,
`matplotlib.pyplot.tripcolor`, `matplotlib.pyplot.triplot`,
`mlab.griddata` and `mpl_toolkits.mplot3d.plot_trisurf`.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/mlab/matplotlib.mlab/ (not sure if that will work)
s/mplot3d/mplot3d.axes3d.Axes3D/

Comment thread doc/api/api_changes.rst Outdated

The ``GraphicsContextBase.get_linestyle`` and
``GraphicsContextBase.set_linestyle`` methods, which effectively had
no effect, have been deprecated.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"effectively had no effect" sounds a bit redundant.

Comment thread doc/api/api_changes.rst Outdated
``NavigationToolbar2.dynamic_update``
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Use :meth:`matplotlib.backend_bases.FigureCanvas.draw_idle` instead.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's FigureCanvasBase, but I'm not sure if that's where one wants to be linking.

Comment thread doc/api/api_changes.rst
matplotlib.delaunay
~~~~~~~~~~~~~~~~~~~

Remove the delaunay triangulation code which is now handled by Qhull

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I can't comment on it, the other instance of qhull should be capitalized to match.

@anntzer

anntzer commented Oct 7, 2017

Copy link
Copy Markdown
Contributor

@QuLogic https://git-scm.com/docs/git-worktree is really practical for this case

Comment thread doc/users/whats_new.rst Outdated
:include-source:
:align: center

data = {'apples':10, 'oranges':15, 'lemons':5, 'limes':20}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be PEP8-'ed... (space after colon)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also (I guess it's kind of too late for this now...) I am really surprised that this does not keep key order (dict implicitly maintain key order on 3.6, but even passing an OrderedDict does not help)

Comment thread doc/users/whats_new.rst Outdated
``ax.tick_params(rotation='auto')`` will enable new behavior: radial tick
labels will be parallel to the circular grid line, and angular tick labels will
be perpendicular to the grid line (i.e., parallel to the outer boundary.)
be perpendicular to the grid line (i.e., parallel to the outer boundary).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just above: "enable the new behavior"

Comment thread doc/users/whats_new.rst Outdated
Annotations now use the default arrow style when setting ``arrowprops={}``,
rather than no arrow (the new behavior actually matches the documentation).
Alternatively, calling ``savefig`` with ``metadata={'creationDate': None}``
will omit the timestamp altogether.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not consistent with the above docs on metadata which say that "Creator" is the only supported key for (e)ps.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, this only applies to the pdf backend.

Comment thread doc/users/whats_new.rst

ax.xaxis.set_tick_params(which='both', rotation=90)


Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just below "Shading can now be toggled etc" to be consistent with the style of other headings

Comment thread doc/users/whats_new.rst

Example
~~~~~~~

@anntzer anntzer Oct 7, 2017 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this entry could be merged with the addition of figure.subplots? subplot2grid should be double-bq'ed

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eh, I like the sorting where they are.

Comment thread doc/users/whats_new.rst Outdated
Extend ``MATPLOTLIBRC`` behavior
--------------------------------

The environmental variable can now specify the full file path or path

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

full file path or directory path? (the sentence is actually not 100% clear although it's not too hard to guess)

Comment thread doc/api/api_changes.rst


:meth:`matpltolib.cbook.CallbackRegistry.process` suppresses exceptions by default
:meth:`matplotlib.cbook.CallbackRegistry.process` suppresses exceptions by default

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a bit below "when it receives AN" (not AND)

@tacaswell tacaswell modified the milestones: 2.1.1 (next bug fix release), 2.1.0-docs Oct 7, 2017
@tacaswell
tacaswell merged commit ed96c22 into matplotlib:v2.1.x Oct 7, 2017
tacaswell added a commit that referenced this pull request Oct 7, 2017
DOC: Re-organize What's new page
@tacaswell

Copy link
Copy Markdown
Member

backported to v2.1.0-doc as a027a02

@QuLogic
QuLogic deleted the whatsnew-plots branch October 7, 2017 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants