Repository navigation
Fix osx busy cursor - #9157
Fix osx busy cursor#9157
Conversation
|
LGTM although I can't actually test it :-) Also, does OSX actually display a busy spinner in that case? (Not that I'd consider that a blocker) |
|
Oh yeah, should have added that this fixes the issue for me! I think one other osx dev should check this before it goes in. It doesn't look like OSX is showing a spinner when I plot and move a very large scatter plot. |
|
What about fixing the problem that it returns null without an exception set? |
|
It should definitely be fixed at some point but I don't think it's release critical, considering that the issue has always been present. |
|
Fair enough. |
dopplershift
left a comment
There was a problem hiding this comment.
I can confirm this fixes the problem for me as well.
Would just like a comment so we don't have to go digging in the future to understand why this is correct.
| case 1: [[NSCursor arrowCursor] set]; break; | ||
| case 2: [[NSCursor crosshairCursor] set]; break; | ||
| case 3: [[NSCursor openHandCursor] set]; break; | ||
| case 4: break; |
There was a problem hiding this comment.
Can we get a comment here about the fact that OS X handles the busy for us and doesn't provide an icon?
Fixes #9156. See #9156 (comment) for more information on the fix.