Skip to content

Fix osx busy cursor - #9157

Merged
tacaswell merged 2 commits into
matplotlib:v2.1.xfrom
dstansby:osx-busy-cursor
Sep 18, 2017
Merged

tacaswell merged 2 commits into
matplotlib:v2.1.xfrom
dstansby:osx-busy-cursor

Conversation

@dstansby

@dstansby dstansby commented Sep 5, 2017

Copy link
Copy Markdown
Member

Fixes #9156. See #9156 (comment) for more information on the fix.

@dstansby dstansby added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Sep 5, 2017
@dstansby dstansby added this to the 2.1 (next point release) milestone Sep 5, 2017
@anntzer

anntzer commented Sep 5, 2017

Copy link
Copy Markdown
Contributor

LGTM although I can't actually test it :-) Also, does OSX actually display a busy spinner in that case? (Not that I'd consider that a blocker)

@dstansby

dstansby commented Sep 5, 2017

Copy link
Copy Markdown
Member Author

Oh yeah, should have added that this fixes the issue for me! I think one other osx dev should check this before it goes in. It doesn't look like OSX is showing a spinner when I plot and move a very large scatter plot.

@dopplershift

Copy link
Copy Markdown
Contributor

What about fixing the problem that it returns null without an exception set?

@anntzer

anntzer commented Sep 5, 2017 •

Copy link
Copy Markdown
Contributor

It should definitely be fixed at some point but I don't think it's release critical, considering that the issue has always been present.

@dopplershift

Copy link
Copy Markdown
Contributor

Fair enough.

@dopplershift dopplershift left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm this fixes the problem for me as well.

Would just like a comment so we don't have to go digging in the future to understand why this is correct.

Comment thread src/_macosx.m
case 1: [[NSCursor arrowCursor] set]; break;
case 2: [[NSCursor crosshairCursor] set]; break;
case 3: [[NSCursor openHandCursor] set]; break;
case 4: break;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get a comment here about the fact that OS X handles the busy for us and doesn't provide an icon?

@tacaswell
tacaswell merged commit 63e2810 into matplotlib:v2.1.x Sep 18, 2017
@dstansby
dstansby deleted the osx-busy-cursor branch September 24, 2017 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants