Skip to content

Document class methods - #9046

Merged
choldgraf merged 2 commits into
matplotlib:masterfrom
dstansby:class-methods
Aug 21, 2017
Merged

choldgraf merged 2 commits into
matplotlib:masterfrom
dstansby:class-methods

Conversation

@dstansby

Copy link
Copy Markdown
Member

This is an attempt to fix #8701. Currently this throws a lot of warnings which need investigating, but building with --allowsphinxwarnings results in correctly documented class pages.

@dstansby dstansby added Documentation Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. labels Aug 16, 2017
@dstansby dstansby added this to the 2.1 (next point release) milestone Aug 16, 2017
Add some more no-index

Remove extra method listings

Fix Figure example section

Escape plot_directive docstring@
@dstansby dstansby changed the title [WIP] Document class methods Document class methods Aug 21, 2017
@dstansby

Copy link
Copy Markdown
Member Author

I think this should now be ready to go. Essentially I've turned on documenting class methods by default, and had to manually disable a few places where they were being duplicated. All the new pages added by @choldgraf should be the same, but I'll double check the circleci build once it is done.

@dstansby

Copy link
Copy Markdown
Member Author

@choldgraf

Copy link
Copy Markdown
Contributor

this sounds like a good addition to me - I guess Figure is probably going to have one of the longer versions of these new pages, yeah? If you double check that the other pages look good then I think we're good to go

@dstansby

Copy link
Copy Markdown
Member Author

Just manually checked all the pages I made changes to, and they look the same as before.

@choldgraf
choldgraf merged commit 2ed56ab into matplotlib:master Aug 21, 2017
@choldgraf

Copy link
Copy Markdown
Contributor

boom!

@tacaswell

Copy link
Copy Markdown
Member

Thanks @dstansby ! This is something I had been dreading fixing!

@dstansby
dstansby deleted the class-methods branch August 21, 2017 19:44
@dstansby

Copy link
Copy Markdown
Member Author

It took me a while to understand the warnings, but I got there eventually (and learnt a bit more about sphinx along the way!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Class pages don't document their methods

3 participants