Repository navigation
Final batch of pylab example moves - #8983
Merged
Merged
Conversation
dstansby
added
Documentation
Release critical
QuLogic
reviewed
Aug 2, 2017
Member
There was a problem hiding this comment.
I'm not sure about the anchored_artists.py example. It seems to be duplicating the classes that already exist in the library, either matplotlib.offsetbox or mpl_toolkits.axes_grid1. Probably most of it can be replaced with suitable imports?
LGTM otherwise.
| @@ -11,7 +11,8 @@ | |||
|
|
|||
|
|
|||
| class AnchoredText(AnchoredOffsetbox): | |||
Member
There was a problem hiding this comment.
I wonder if we need this class when there's a matplotlib.offsetbox.AnchoredText implementation already?
| @@ -26,8 +27,8 @@ class AnchoredSizeBar(AnchoredOffsetbox): | |||
| def __init__(self, transform, size, label, loc, | |||
Member
There was a problem hiding this comment.
And AnchoredSizeBar is in mpl_toolkits.axes_grid1.AnchoredSizeBar.
NelleV
reviewed
Aug 3, 2017
| ) | ||
|
|
||
| #fig.subplots_adjust(top=0.99, bottom=0.01, left=0.2, right=0.99) | ||
| # fig.subplots_adjust(top=0.99, bottom=0.01, left=0.2, right=0.99) |
Member
There was a problem hiding this comment.
I guess at some point we should clean this up and just delete those lines of codes.
Merged
Contributor
|
Partially resolves #8922 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Again, first commit is moves, second commit is PEP8, third commit is link fixing.