Skip to content

Separating examples with multiple plots into separate blocks - #8899

Merged
phobson merged 6 commits into
matplotlib:masterfrom
tonyyli:sep-multiplot
Jul 20, 2017
Merged

phobson merged 6 commits into
matplotlib:masterfrom
tonyyli:sep-multiplot

Conversation

@tonyyli

@tonyyli tonyyli commented Jul 16, 2017

Copy link
Copy Markdown
Contributor

PR Summary

Added #####... separators to 34 examples which draw multiple plots (i.e. multiple calls to plt.figure(), plt.show(), and/or plt.subplots()).

This addresses one of the issues mentioned in #8885:

Find examples w/ multiple plots generated and add sphinx-gallery ########## blocks + rST so that it's more narrative

@choldgraf @NelleV

@tonyyli tonyyli mentioned this pull request Jul 16, 2017
3 of 4 tasks
Lognorm: Instead of pcolor log10(Z1) you can have colorbars that have
the exponential labels using a norm.
'''
###############################################################################

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tacaswell

Copy link
Copy Markdown
Member

Looks like the sankey example has a whitespace issue?

Warning, treated as error:
/home/travis/build/matplotlib/matplotlib/doc/gallery/api/sankey_basics.rst:61:Unexpected indentation.
Building HTML failed.

@tacaswell tacaswell added this to the 2.1 (next point release) milestone Jul 18, 2017
@tonyyli

tonyyli commented Jul 18, 2017

Copy link
Copy Markdown
Contributor Author

Hm, let's see if this fixes it ...

@choldgraf

Copy link
Copy Markdown
Contributor

Travis is giving a unicode error...could this be related to sphinx-gallery/sphinx-gallery#269 ?

@tonyyli if so, I don't think this is something you can debug right now...lemme look into it!

@QuLogic

QuLogic commented Jul 20, 2017

Copy link
Copy Markdown
Member

You could also temporarily revert the change to the accented_text.py file for the time being.

@tonyyli

tonyyli commented Jul 20, 2017

Copy link
Copy Markdown
Contributor Author

Was wondering about that -- let's go with @QuLogic 's suggestion for now. I'll revert the accented_text.py changes.

@choldgraf

Copy link
Copy Markdown
Contributor

this sounds like a good plan to me!

@choldgraf

Copy link
Copy Markdown
Contributor

Tests are passing now and I think this is a nice addition to the docs. Nicely done @tonyyli 😄 🎉 🎈 🍺

@choldgraf

Copy link
Copy Markdown
Contributor

@tacaswell for some reason I still can't merge...looks like I'm a part of the organization but don't have merge rights? I definitely clicked the button in the email :-)

@NelleV maybe you wanna marge in place of me?

@phobson

phobson commented Jul 20, 2017

Copy link
Copy Markdown
Member

@choldgraf Do you see the green review button when you looked at the changed files? can you "approve" the PR?

@choldgraf

Copy link
Copy Markdown
Contributor

yep...

@phobson
phobson merged commit b781623 into matplotlib:master Jul 20, 2017
@phobson

phobson commented Jul 20, 2017

Copy link
Copy Markdown
Member

weird that you couldn't merge. glad you can approve PRs though

@choldgraf

Copy link
Copy Markdown
Contributor

¯_(ツ)_/¯

@QuLogic

QuLogic commented Jul 20, 2017 •

Copy link
Copy Markdown
Member

I don't think you need any special permission to leave reviews (approval or otherwise), but they show up as grey instead of green/red and don't count for 'needs approval' (if enabled).

@choldgraf

Copy link
Copy Markdown
Contributor

hmmm, not sure what I should do to get merge access in that case

@tonyyli

tonyyli commented Jul 21, 2017

Copy link
Copy Markdown
Contributor Author

@choldgraf hope you got/get it figured out soon.

In the meantime, thanks all for reviewing and merging!

@tonyyli
tonyyli deleted the sep-multiplot branch July 30, 2017 17:47
@LindyBalboa

Copy link
Copy Markdown
Contributor

partially resolves #8922

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants