Skip to content

FIX: Dev installation instructions documentation issue - #8888

Merged
tacaswell merged 1 commit into
matplotlib:masterfrom
roopchansinghv:scipy2017SprintVR
Jul 16, 2017
Merged

tacaswell merged 1 commit into
matplotlib:masterfrom
roopchansinghv:scipy2017SprintVR

Conversation

@roopchansinghv

@roopchansinghv roopchansinghv commented Jul 15, 2017 •

Copy link
Copy Markdown
Contributor

Making installation and build instructions more explicit, and linking to already available instructions in another portion of the Matplotlib documentation website.

Aimed at addressing "Alternative dev install instructions #7319":

#7319

Closes #7319

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/whats_new.rst if major new feature
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@tacaswell tacaswell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditional on travis passing.

Comment thread doc/devel/contributing.rst Outdated
a local environment on your machine.

Follow the instructions detailed
`here <http://matplotlib.org/users/installing.html#installing-from-source>`_ to set

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a Sphinx/reST link.

Making installation and build instructions more explicit, and linking to
already available instructions in another portion of the Matplotlib
documentation website.

Aimed at addressing "Alternative dev install instructions #7319":

   #7319
@roopchansinghv

Copy link
Copy Markdown
Contributor Author

Link changed to internal reST.

@tacaswell
tacaswell merged commit 380670b into matplotlib:master Jul 16, 2017
@tacaswell

Copy link
Copy Markdown
Member

@roopchansinghv Thank you and congratulations on your first Matplotlib contribution 🎉 . Hopefully we will hear from you again!

@roopchansinghv
roopchansinghv deleted the scipy2017SprintVR branch July 16, 2017 15:52
@QuLogic QuLogic added this to the 2.1 (next point release) milestone Aug 7, 2017
@anntzer anntzer mentioned this pull request Nov 28, 2017
1 of 6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Alternative dev install instructions

3 participants