Skip to content

Mask invalid values by default when setting log scale#8836

Merged
NelleV merged 5 commits into
matplotlib:masterfrom
dstansby:log-mask
Jul 15, 2017
Merged

Mask invalid values by default when setting log scale#8836
NelleV merged 5 commits into
matplotlib:masterfrom
dstansby:log-mask

Conversation

@dstansby

@dstansby dstansby commented Jul 3, 2017

Copy link
Copy Markdown
Member

This supersedes #8056 and #8537. See especially #8537 for previous discussion.

This should fix a few bugs: #8045, #8783

@dstansby dstansby added the API: changes Changes to the public API, typically requiring deprecation. label Jul 3, 2017
@dstansby dstansby added this to the 2.1 (next point release) milestone Jul 3, 2017
@tacaswell

Copy link
Copy Markdown
Member

On the bright side our test suite catches the API change!

@dstansby

dstansby commented Jul 4, 2017

Copy link
Copy Markdown
Member Author

I'm completely baffled by the travis failure on the .svg figure. I can't reproduce it on OSX or Linux (Python 3.6.1, Inkscape 0.92.1). Might it be because travis is using version inkscape_0.48.4-3ubuntu2?

@dstansby

dstansby commented Jul 4, 2017

Copy link
Copy Markdown
Member Author

Close, but no cigar. Force installing the latest stable build of Inkscape gives an error of 0.001 vs. 0.044 for the default version. Perhaps this is going to need a custom tolerance on the image comparison?

https://travis-ci.org/dstansby/matplotlib/jobs/250114851#L3193 is a branch with latest stable Inkscape

@tacaswell

Copy link
Copy Markdown
Member

Can you re-generate the svg and add it to the patch. A while ago we changed how the number is the SVG output were encoded which resulted in similar inkscape version dependent failures.

A feature of the vector outputs is that different text can result in the same image (which is why we test on comparing the rasterizations not the text), but it can lead to small issues like this.

@dstansby

dstansby commented Jul 6, 2017

Copy link
Copy Markdown
Member Author

🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API: changes Changes to the public API, typically requiring deprecation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants