Repository navigation
Conversation
Member
Author
|
The contour_hatching test still fails because the gray shades are not the same as they were. I can fix this by regenerating the images, but those images show a much bigger problem: the pdf and svg test images are very different from the png. See #3841. It's not clear to me whether the problem is as described there. In any case, in the test images it looks like the alpha is applied to the hatch in the svg and pdf but not in the png. The result is actually better with the png. |
Member
|
Popping back into 3 in case @efiring feels inspired... Its also possible some of the alpha inconsistencies have been worked on? |
Locator.tick_values() returns levels beyond the data limits. In the case of LogLocator with a small data range, the overrun can be large because it is expanding to the decade points. In addition, no account was being taken of the "extend" kwarg. With this changeset, the outermost levels will be the miminum required to include the data interval in the default case, and will be reduced when "extend" is used so that some of the data range will fall in the extended sections. This is expected to be rare, however; normally the "extend" kwarg would be used only when levels are explicitly set, not auto-selected with a Locator.
This puts the hatches in the same order as they were in the reference figure, but the images still don't match because the gray shades are not the same as they were. Furthermore, looking at the original reference figures shows that the pdf and svg backends handle the alpha differently than the agg backend. Not sure what to do about that.
efiring
force-pushed
the
contour_log_extension
branch
from
May 30, 2018 19:58
399d57a to
91a38f7
Compare
6 tasks
Member
Author
|
Closing in favor of #11412. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is inspired by, and partially derived from, #8806 by @Tuan333.