Skip to content

sort input files - #8747

Merged
QuLogic merged 1 commit into
matplotlib:masterfrom
bmwiedemann:sort
Jun 12, 2017
Merged

QuLogic merged 1 commit into
matplotlib:masterfrom
bmwiedemann:sort

Conversation

@bmwiedemann

Copy link
Copy Markdown
Contributor

when building packages (e.g. for openSUSE Linux)
(random) filesystem order of input files
influences ordering of functions in the output,
thus without the patch, builds (in disposable VMs) would usually differ.

See https://reproducible-builds.org/ for why this matters.

when building packages (e.g. for openSUSE Linux)
(random) filesystem order of input files
influences ordering of functions in the output,
thus without the patch, builds (in disposable VMs) would usually differ.

See https://reproducible-builds.org/ for why this matters.
@tacaswell tacaswell added this to the 2.1 (next point release) milestone Jun 12, 2017
@WeatherGod

Copy link
Copy Markdown
Member

There is the same error in two of the CI builds. I restarted them, but I don't know if that'll make a difference. The errors are not one of the usual transient ones.

@jenshnielsen

Copy link
Copy Markdown
Member

I guess it's the error fixed by #8737

@dstansby

dstansby commented Jun 12, 2017 •

Copy link
Copy Markdown
Member

Yep, I think CI is broken unless someone puts in a PR to force numpy!=1.13 to be installed or #8737 is merged.

@QuLogic
QuLogic merged commit 545af7a into matplotlib:master Jun 12, 2017
@bmwiedemann
bmwiedemann deleted the sort branch June 14, 2017 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants