Skip to content

Plot errorbars when fmt == 'none' - #8163

Merged
tacaswell merged 4 commits into
matplotlib:v2.0.xfrom
dstansby:errbar-none-fmt
Mar 11, 2017
Merged

tacaswell merged 4 commits into
matplotlib:v2.0.xfrom
dstansby:errbar-none-fmt

Conversation

@dstansby

Copy link
Copy Markdown
Member

Fixes #8117.

Comment thread lib/matplotlib/tests/test_axes.py Outdated
plotline, _, barlines = plt.errorbar(x, y, xerr=1, yerr=1, fmt='none')
assert plotline is None
for errbar in barlines:
assert np.any(errbar.get_color() != [0, 0, 0, 0])

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is the best way to check that the errorbars aren't see-through, so other suggestions welcome.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This color should be 'C0'? I would test against that.

@dstansby dstansby added this to the 2.0.1 (next bug fix release) milestone Feb 27, 2017
@tacaswell tacaswell added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Feb 27, 2017
ax.set_title('Errorbar upper and lower limits')


def test_errobar_nonefmt():

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still need @cleanup on 2.0.x.

@NelleV NelleV left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dstansby ! This looks good.

@NelleV NelleV changed the title Plot errorbars when fmt == 'none' [MRG+1] Plot errorbars when fmt == 'none' Mar 8, 2017
@NelleV

NelleV commented Mar 11, 2017

Copy link
Copy Markdown
Member

Anyone wants to give another look at this PR?

@afvincent afvincent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too :).

@afvincent afvincent changed the title [MRG+1] Plot errorbars when fmt == 'none' [MRG+2] Plot errorbars when fmt == 'none' Mar 11, 2017
@afvincent

Copy link
Copy Markdown
Contributor

Might be worth to re-run AppVeyor (which does not seem to have been run) before merging?

@tacaswell

Copy link
Copy Markdown
Member

Appveyor does not run on the 2.0.x branch

@afvincent

Copy link
Copy Markdown
Contributor

Ah, this might be the explanation then 😄!

@tacaswell
tacaswell merged commit b6f17f3 into matplotlib:v2.0.x Mar 11, 2017
@QuLogic QuLogic changed the title [MRG+2] Plot errorbars when fmt == 'none' Plot errorbars when fmt == 'none' Mar 11, 2017
@dstansby
dstansby deleted the errbar-none-fmt branch March 12, 2017 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants