Repository navigation
Remove support for -dbackend argv. - #8148
Merged
Merged
Conversation
QuLogic
approved these changes
Feb 25, 2017
QuLogic
requested changes
Feb 25, 2017
QuLogic
left a comment
QuLogic
left a comment
Member
There was a problem hiding this comment.
Changed my mind because there are still a few places that you missed:
- doc/devel/contributing.rst
- doc/faq/environment_variables_faq.rst
- doc/users/prev_whats_new/whats_new_0.98.4.rst (iffy)
anntzer
force-pushed
the
remove--dbackend-flag
branch
from
February 25, 2017 21:46
e0dd944 to
2f47d51
Compare
Contributor
Author
|
Thanks for the quick review, fixed the points you mentioned, with the exception of the 0.98.4 whatsnew (I'd rather not touch old whatsnews). |
QuLogic
approved these changes
Feb 26, 2017
Member
|
Can you start a 'removed_code' file in API changes? Other than that 👍 |
Support for setting the backend with `-dbackend` was deprecated in 1.5.
Contributor
Author
|
Done. |
anntzer
force-pushed
the
remove--dbackend-flag
branch
from
February 26, 2017 07:30
2f47d51 to
781872e
Compare
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for setting the backend with
-dbackendwas deprecated in 1.5 (#3710).