-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
Update examples/README.txt. #8099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
afvincent
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me. Thanks for updating some old links or toolkit names!
Is it normal that not all the sections present in the examples web page are listed in the current README file? If I do not forget any:
colorfrontpage(well maybe this one should not be listed ^^)images_contours_and_fieldslines_bars_and_markerspie_and_polar_chartspyplot(BTW, why are there somewhats_new_*.pyfiles?)scalesshapes_and_collectionsshowcasespecialty_plotsstatisticsstyle_sheetssubplots_axes_and_figurestext_labels_and_annotationsticks_and_spines
are missing.
Should we add entries for all of them in the current bullet list or simply wait for the expected documentation overhaul likely to happen during the March “docathon?”
examples/README.txt
Outdated
| use the pytest tests which perform automatic image comparison.) | ||
|
|
||
| * units - working with unit data an custom types in matplotlib | ||
| * units - Working with unit data an custom types in Matplotlib. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
“… unit data an custom…” <- “… unit data and custom…”? Edit: typo…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
e177632 to
add8155
Compare
|
I'm sure we can add a TODO for the docathon regarding the missing entries :-) |
afvincent
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with the idea of a “to-do” for the docathon about adding the missing entries to this README file (or tweaking it in any relevant way after the changes that are likely to occur to the examples).
|
Travis' unhappiness seems unrelated (the failure is due to the flaky |
All's in the title.