Repository navigation
Fix streamplot for non-square grids. - #789
Merged
Merged
Conversation
tonysyu
commented
Mar 22, 2012
Contributor
- Order of x/y was switched.
- Additional cleanup (remove unused import and old comment, improve docstring).
* Order of x/y was switched. * Additional cleanup (remove unused import and old comment, improve docstring).
|
I just noticed that the patches for the arrows on the streamlines are not returned - so you can't remove them from the axes instance or alter their properties. Perhaps a streamline collection object could be created (and returned) that includes both the streamline line collection and the arrow patch collection. |
Contributor
Author
|
@jswhit Yeah, the plan was to add this at some point, but it fell off my radar. Thanks for the reminder I just submitted a PR (#803) to return an arrow patch collection. I think creating a custom streamline collection object is a bit too much (work); instead, I just return separate collections for the streamlines and arrow patches. |
efiring
added a commit
that referenced
this pull request
Apr 16, 2012
Fix streamplot for non-square grids.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.