Api doc backport no imag build #7779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, don't include tests in binary distributions.
Update to include details about how to re-enable.
QuLogic
reviewed
Jan 10, 2017
doc/api/api_changes.rst
Outdated
| raised a warning. As of matplotlib 2.0.0, using the old names raises a | ||
| deprecation warning. In the future, using the old names will raise an error. | ||
|
|
||
| Default install does not include test images |
Member
There was a problem hiding this comment.
does not include -> no longer includes
doc/api/api_changes.rst
Outdated
| To reduce the default size of wheels and source installs, the tests | ||
| and baseline images are no longer included by default. | ||
|
|
||
| To restore installing the tests and images have a `setup.cfg` with :: |
Member
There was a problem hiding this comment.
images have -> images, use
(or add)
doc/devel/contributing.rst
Outdated
| all of the files will be copied to the installation directory however, | ||
| you will have to rerun this command every time the source is changed. | ||
| you will have to rerun this command every time the source is changed. Additionally you will | ||
| need to copy :file:`setup.cfg.template` to :file:`setup.cfg` and edit to contain :: |
Member
Author
|
Apparently we have moved to using develop on the master branch, but not in 2.x.... |
NelleV
approved these changes
Jan 13, 2017
Member
NelleV
left a comment
NelleV
left a comment
There was a problem hiding this comment.
Apart from the minor comments (which IMO are minor enough that they can be ignored), this looks good.
👍
doc/api/api_changes.rst
Outdated
| Default install does not include test images | ||
| -------------------------------------------- | ||
|
|
||
| To reduce the default size of wheels and source installs, the tests |
Member
There was a problem hiding this comment.
Isn't "default" an extra word here?
setup.cfg.template
Outdated
| #suppress = False | ||
|
|
||
| [packages] | ||
| # There are a number of subpackages of matplotlib that are considered |
Member
There was a problem hiding this comment.
matplotlib -> Matplotlib
(trying to catch them as they come…)
NelleV
changed the title
tacaswell
force-pushed
the
API_DOC_backport_no_imag_build
branch
from
08be52f to
9cff712
Compare
tacaswell
force-pushed
the
API_DOC_backport_no_imag_build
branch
from
9cff712 to
ca6bb75
Compare
Member
Author
|
Took 3 tries, but I think I got all of them. |
NelleV
approved these changes
Jan 13, 2017
Member
|
Thanks! |
QuLogic
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #7757 + docs