Repository navigation
For make raw_input compatible with python3 - #7729
Merged
Merged
Conversation
Member
|
Can you either un-densify this (we enforce pep8/pycodestlye as part of our test suite) or use |
tacaswell
requested changes
Jan 3, 2017
tacaswell
left a comment
tacaswell
left a comment
Member
There was a problem hiding this comment.
Either add new lines or use from six.moves import input
Contributor
Author
|
Ok @tacaswell first let me add new lines if its work for pep8 issue then done. Otherwise I will use |
This commit remove the pep8 warning from this file
Contributor
Author
|
@tacaswell its done please review it and let me know if any other modification required. |
Current coverage is 62.12% (diff: 100%)@@ master #7729 diff @@
==========================================
Files 174 174
Lines 56028 56028
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 34805 34805
Misses 21223 21223
Partials 0 0
|
tacaswell
approved these changes
Jan 4, 2017
Member
|
Please do not backport this until after 2.0 final is out. |
Member
|
Backported to |
QuLogic
pushed a commit
that referenced
this pull request
Jan 30, 2017
For make raw_input compatible with python3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #7388