Skip to content

Fix table identation in docs#7710

Closed
akarilimano wants to merge 1 commit into
matplotlib:masterfrom
akarilimano:akarilimano-patch-1
Closed

Fix table identation in docs#7710
akarilimano wants to merge 1 commit into
matplotlib:masterfrom
akarilimano:akarilimano-patch-1

Conversation

@akarilimano

Copy link
Copy Markdown

Remove htmlonly directive which breaks table identation as described at #7300

'htmlonly' directive is used only in 17 files in matplotlib docs. As every other usage preceeds some additional information like release date, I belive this to be some sort of typo. But I am not completely sure.

Remove htmlonly directive which breaks table identation.
@jenshnielsen

Copy link
Copy Markdown
Member

Tentative 👍 It seems likely that the line below would not render correctly in the latex/pdf version of the docs (At least when originally added). Before merging this we should probably verify that the docs still build with latex

@Kojoley

Kojoley commented Dec 30, 2016

Copy link
Copy Markdown
Member

Closes #7300

@Kojoley Kojoley added this to the 2.0.1 (next bug fix release) milestone Dec 30, 2016
@codecov-io

Copy link
Copy Markdown

Current coverage is 62.07% (diff: 100%)

Merging #7710 into master will not change coverage

@@             master      #7710   diff @@
==========================================
  Files           174        174          
  Lines         56022      56022          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          34775      34775          
  Misses        21247      21247          
  Partials          0          0          

Powered by Codecov. Last update 22708ef...d406de6

@QuLogic

QuLogic commented Dec 30, 2016

Copy link
Copy Markdown
Member

Unfortunately, \mathcircled fails to render in LaTeX; it seems to be a Matplotlib speciality.

@NelleV NelleV left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @QuLogic mentions, this breaks the PDF output and thus cannot be merged.

@anntzer

anntzer commented Jan 23, 2017

Copy link
Copy Markdown
Contributor

latex does provide \textcircled (it warns "invalid in math mode" but still works, in local tests...)

I would suggest supporting \textcircled in mathtext and deprecating \mathcircled? No point in reinventing our own dialect of latex...

@NelleV

NelleV commented Feb 16, 2017

Copy link
Copy Markdown
Member

Hi @akarilimano
Do you plan on working on this any further?

@akarilimano

Copy link
Copy Markdown
Author

@NelleV, sorry, I'm not sure what I can do here. Any tips? Change to \textcircled everywhere?

@QuLogic QuLogic modified the milestones: 2.0.1 (next bug fix release), 2.0.2 (next bug fix release) May 3, 2017
@tacaswell

Copy link
Copy Markdown
Member

Closing as there is not much we can do without overhauling \mathcircled vs \textcircled.

Sorry @akarilimano 😞 Hopefully we will hear from you again!

@tacaswell tacaswell closed this Jul 11, 2017
@QuLogic QuLogic modified the milestones: unassigned, 2.0.3 (next bug fix release) Jul 11, 2017
@anntzer anntzer mentioned this pull request Mar 26, 2019
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants