Skip to content

Conversation

@QuLogic
Copy link
Member

@QuLogic QuLogic commented Dec 15, 2016

As this breaks linkchecker, I would like to self-merge to get Travis working again.

@QuLogic QuLogic added this to the 2.0 (style change major release) milestone Dec 15, 2016
@QuLogic
Copy link
Member Author

QuLogic commented Dec 15, 2016

Oops, I misread what it was looking for; with 1.5.1, it creates source as <fullname>.<ext>, but in previous versions it did <basename>.<ext>. We can configure <ext>, but as far as I can tell, not whether it uses the basename or the fullname.

The faq/howto_faq.rst is the only explicit link to the sources we have; maybe we ought to just remove it?

@tacaswell
Copy link
Member

👍 to just remove the link.

In Sphinx 1.5, the naming of the reST source files has changed, so it's
not possible to make an explicit link that works across versions. And
users can just follow the "Show Source" link mentioned in the text
anyway.
@QuLogic QuLogic changed the title DOC: Remove extra .txt for sources in Sphinx 1.5. DOC: Remove explicit link to source file for Sphinx 1.5 compat. Dec 15, 2016
@tacaswell tacaswell merged commit 633add3 into matplotlib:v2.x Dec 15, 2016
@QuLogic QuLogic deleted the sphinx-151 branch December 15, 2016 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants