Skip to content

ticker: cast argument to int to avoid numpy warning#7583

Merged
QuLogic merged 1 commit into
matplotlib:v2.xfrom
efiring:ticker_int_N
Dec 7, 2016
Merged

ticker: cast argument to int to avoid numpy warning#7583
QuLogic merged 1 commit into
matplotlib:v2.xfrom
efiring:ticker_int_N

Conversation

@efiring

@efiring efiring commented Dec 7, 2016

Copy link
Copy Markdown
Member

No description provided.

@efiring efiring added this to the 2.0 (style change major release) milestone Dec 7, 2016
@efiring efiring changed the title ticker: cast argument to int to avoid numpy warning [MRG] ticker: cast argument to int to avoid numpy warning Dec 7, 2016
@efiring

efiring commented Dec 7, 2016

Copy link
Copy Markdown
Member Author

This is a very simple one; there is no need for an extended review. @QuLogic, it is in response to a problem you found (numpy warning), so if it looks OK to you, please go ahead and merge it.

@phobson

phobson commented Dec 7, 2016

Copy link
Copy Markdown
Member

I'm happy to merge, but I'm really surprised that b//2 wasn't sufficiently int-like for numpy.

@phobson phobson self-requested a review December 7, 2016 23:05
@phobson

phobson commented Dec 7, 2016

Copy link
Copy Markdown
Member

@efiring & @tacaswell: what's the backport strategy (if any) when merging into a maintenance branch? In other words, does this need to go into master too? And if so, how?

@QuLogic

QuLogic commented Dec 7, 2016

Copy link
Copy Markdown
Member

a//b with a or b as floats is unfortunately still a float.

@QuLogic QuLogic merged commit 462fe6d into matplotlib:v2.x Dec 7, 2016
@QuLogic

QuLogic commented Dec 7, 2016

Copy link
Copy Markdown
Member

@phobson v2.x is periodically merged up to master.

@QuLogic QuLogic changed the title [MRG] ticker: cast argument to int to avoid numpy warning ticker: cast argument to int to avoid numpy warning Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants