Skip to content

Check at least one argument is provided for plt.table - #7522

Merged
NelleV merged 1 commit into
matplotlib:masterfrom
dstansby:table-argcheck
Nov 28, 2016
Merged

NelleV merged 1 commit into
matplotlib:masterfrom
dstansby:table-argcheck

Conversation

@dstansby

Copy link
Copy Markdown
Member

Fixes #7519.

  • ValueError seemed to be the most suitable exception to raise, but I might be wrong.
  • Is it worth adding a test for this or not?

@efiring efiring left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@efiring

efiring commented Nov 27, 2016

Copy link
Copy Markdown
Member

ValueError is appropriate. I do not think a test should be added for this.

@efiring efiring changed the title Check at least one argument is provided for plt.table [MRG+1] Check at least one argument is provided for plt.table Nov 27, 2016
@NelleV
NelleV merged commit e0fcf3f into matplotlib:master Nov 28, 2016
@NelleV

NelleV commented Nov 28, 2016

Copy link
Copy Markdown
Member

Thanks @dstansby for the patch!

@QuLogic

QuLogic commented Nov 28, 2016

Copy link
Copy Markdown
Member

Backport?

@efiring

efiring commented Nov 28, 2016

Copy link
Copy Markdown
Member

Sure, go ahead.

QuLogic pushed a commit that referenced this pull request Dec 7, 2016
Check at least one argument is provided for plt.table
@QuLogic QuLogic added this to the 2.0 (style change major release) milestone Dec 7, 2016
@QuLogic QuLogic changed the title [MRG+1] Check at least one argument is provided for plt.table Check at least one argument is provided for plt.table Dec 7, 2016
@QuLogic

QuLogic commented Dec 7, 2016

Copy link
Copy Markdown
Member

Backported to v2.x as aef8acd.

@dstansby
dstansby deleted the table-argcheck branch December 27, 2016 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants