BUG: make autoscale('tight') set margins to zero; closes #6968 #7458
+72
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
added
the
Release critical
tacaswell
approved these changes
Nov 14, 2016
tacaswell
changed the title
NelleV
approved these changes
Nov 14, 2016
dopplershift
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the first commit of #7024 and keeps the second (the test), so it is an alternative.
The operative part is simply setting the
Axes._xmarginand/or_ymarginto zero inautoscale('tight'). This is necessary to maintain behavior consistent with the docstring. The changes inautoscale_vieware a description of the tight kwarg in the docstring, and a change in a large 'if' block to improve readability by putting the bail-out condition first, reducing indentation, and adding a comment. There is no functional change inautoscale_view.