Skip to content

Moved python files from doc/pyplots to examples folder - #7398

Merged
NelleV merged 4 commits into
matplotlib:masterfrom
wgranados:master
Nov 5, 2016
Merged

Moved python files from doc/pyplots to examples folder#7398
NelleV merged 4 commits into
matplotlib:masterfrom
wgranados:master

Conversation

@wgranados

@wgranados wgranados commented Nov 3, 2016

Copy link
Copy Markdown

Completed the first two changes specified in #7390 . When I was looking through the pyplots files with grep I didn't spot any places where the stdlib random module was used in stead of the numpy.random module.

William Granados
moved python files from doc/pyplots to examples folder
7d64c41 
updated the dynamic links for doc/pyplots to examples/pyplots

fixed random state for reproducibility in pyplot examples
@tacaswell tacaswell added this to the 2.0.1 (next bug fix release) milestone Nov 3, 2016
@tacaswell tacaswell changed the title Moved python files from doc/pyplots to examples folder [MRG+1] Moved python files from doc/pyplots to examples folder Nov 3, 2016
tacaswell
tacaswell approved these changes Nov 3, 2016
View reviewed changes

@tacaswell tacaswell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modulo the docs building cleanly on travis

@NelleV

NelleV commented Nov 4, 2016

Copy link
Copy Markdown
Member

That's great!
Thank you for doing this work.

@NelleV NelleV changed the title [MRG+1] Moved python files from doc/pyplots to examples folder [MRG+2] Moved python files from doc/pyplots to examples folder Nov 4, 2016
QuLogic
QuLogic reviewed Nov 4, 2016
View reviewed changes
Comment thread doc/devel/documenting_mpl.rst
taken, these figures can be included in the usual way::

.. plot:: pyplots/tex_unicode_demo.py
.. plot:: mpl_examples/pyplots/tex_unicode_demo.py

@QuLogic QuLogic Nov 4, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this and the section above is relevant any more? I don't see either README or make.py in the original doc/pyplots.

@NelleV

NelleV commented Nov 4, 2016

Copy link
Copy Markdown
Member

The failing tests are pep8 related error, which we probably don't want to fix in this PR…
If we merge, what's going to happen? How are the pep8 tests ran?

@QuLogic

QuLogic commented Nov 4, 2016

Copy link
Copy Markdown
Member

You can add those files to the list near the end of lib/matplotlib/tests/test_coding_standards.py to ignore the pep8 warnings for now.

William Granados
added examples from pyplots to ignore list for pep8 coding standards
0543f77 
fixed typo from previous commit; redirected to wrong file path
@efiring

efiring commented Nov 5, 2016

Copy link
Copy Markdown
Member

Strangely, the pep8 checker doesn't ignore the excluded files, it checks to make sure they need to be excluded!

ValueError: Some exclude patterns were unnecessary as the files they pointed to either passed the PEP8 tests or do not point to a file:
  */pyplots/pyplot_scales.py
  */pyplots/pyplot_text.py
  */pyplots/pyplot_three.py
  */pyplots/whats_new_99_mplot3d.py

@NelleV

NelleV commented Nov 5, 2016

Copy link
Copy Markdown
Member

The strategy implemented on #7403 which runs flake8 on diffs fixes the issue we have on this PR.

Currently, there is a test that ensures that blacklisted files need to be blacklisted. Hence the new failure.

William Granados
Merge pull request #1 from NelleV/wgma00_master
ce661b0 
FIX pep8 failed as some files are pep8 compliant
@NelleV
NelleV merged commit 6709b59 into matplotlib:master Nov 5, 2016
NelleV added a commit that referenced this pull request Nov 5, 2016
@NelleV
Merge pull request #7398 from wgma00/master
263e675 
Moved python files from doc/pyplots to examples folder
@NelleV

NelleV commented Nov 5, 2016

Copy link
Copy Markdown
Member

Thanks @wgma00 for the patch!

Cherry-pick in 2.0 with 263e675

@QuLogic QuLogic changed the title [MRG+2] Moved python files from doc/pyplots to examples folder Moved python files from doc/pyplots to examples folder Nov 5, 2016
This was referenced Nov 5, 2016
Closed
Closed
@tacaswell

tacaswell commented Nov 9, 2016

Copy link
Copy Markdown
Member

Complaining that an excluded file passes is a feature of the system to (slowly) ratchet our way to PEP8 compliance (so we do not accidentally fix a file and then break it again).

@QuLogic QuLogic modified the milestones: 2.0.1 (next bug fix release), 2.0 (style change major release) Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuLogic QuLogic QuLogic left review comments
@NelleV NelleV NelleV approved these changes
@tacaswell tacaswell tacaswell approved these changes

Assignees

No one assigned

Labels

Documentation

Projects

None yet

Milestone

v2.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@wgranados @NelleV @QuLogic @efiring @tacaswell