Boxplot zorder kwarg #7178
Boxplot zorder kwarg #7178
Conversation
| # empty list of xticklabels | ||
| datalabels = [] | ||
|
|
||
| zorder = mlines.Line2D.zorder |
There was a problem hiding this comment.
I have a weak preference for this continuing to track mlines.Line2D.zorder by default, but could very easily be talked into change it.
|
It is low-risk and an oversight in the API so I think it is reasonable to backport to 2.x. Open to anyone talking me out of this position. |
lib/matplotlib/axes/_axes.py
Outdated
| labels=None, flierprops=None, medianprops=None, | ||
| meanprops=None, capprops=None, whiskerprops=None, | ||
| manage_xticks=True, autorange=False): | ||
| manage_xticks=True, autorange=False, zorder=2): |
There was a problem hiding this comment.
It is better to have zorder=None here so anyone who want to use default value can pass None explicitly.
There was a problem hiding this comment.
Good idea. I debated doing it this way, but streamplot had a default zorder of 2 IIRC, so I went with that convention.
I'll make the change in a bit.
|
If streamplot() still has a hardcoded property kwarg, then that is a bug On Mon, Sep 26, 2016 at 2:02 PM, Ben Congdon notifications@github.com
|
bcongdon
force-pushed
the
boxplot-zorder
branch
2 times, most recently
from
9fe3a36 to
0723cd5
Compare
|
@WeatherGod bug seems a bit strong, just one more piece of technical debt 😉 |
|
It looks like |
|
On 2016/09/26 1:55 PM, Ben Congdon wrote:
A separate PR would be good. |
lib/matplotlib/axes/_axes.py
Outdated
| boxprops=None, whiskerprops=None, flierprops=None, | ||
| medianprops=None, capprops=None, meanprops=None, | ||
| meanline=False, manage_xticks=True): | ||
| meanline=False, manage_xticks=True, zorder=2): |
There was a problem hiding this comment.
Can you change this to None too?
lib/matplotlib/axes/_axes.py
Outdated
| stats['cihi'] = ci[1] | ||
|
|
||
| # Use default zorder if none specified | ||
| if zorder is None: |
There was a problem hiding this comment.
This should be moved to bxp and just let the None pass through this function.
bcongdon
force-pushed
the
boxplot-zorder
branch
from
0723cd5 to
8c90b1c
Compare
|
I made the requested change. Any insight as to why the tests are failing? |
|
the travis test was flaky, that test is known-fail on windows that we have not dealt with yet. |
|
Thanks @bcongdon ! |
Boxplot zorder kwarg
|
Backported to v2.x via e801685. |
QuLogic
modified the milestones:
2.0 (style change major release),
2.0.1 (next bug fix release)
8 participants
boxplotnow accepts thezorderkwarg to set the zorder of the drawn boxplot in the plotting function.Addresses #7171