Skip to content

Uncaught exns are fatal for PyQt5, so catch them. - #7052

Merged
tacaswell merged 1 commit into
matplotlib:masterfrom
anntzer:catch-exceptions-in-qt5-draw-prevents-abort
Sep 7, 2016
Merged

Uncaught exns are fatal for PyQt5, so catch them.#7052
tacaswell merged 1 commit into
matplotlib:masterfrom
anntzer:catch-exceptions-in-qt5-draw-prevents-abort

Conversation

@anntzer

@anntzer anntzer commented Sep 7, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor

See discussion starting at #6816 (comment).

Minimal example:

from matplotlib import pyplot as plt
plt.gcf().canvas.mpl_connect("draw_event", lambda event: 1/0)
plt.show()

@WeatherGod

WeatherGod commented Sep 7, 2016

Copy link
Copy Markdown
Member

Looks good to me. The Appveyor failure does seem un-related, but possibly not transient?

Should this get cherry-picked to 1.5.x as well as 2.x?

@anntzer

anntzer commented Sep 7, 2016

Copy link
Copy Markdown
Contributor Author

I'd suggest doing so.

@jenshnielsen

jenshnielsen commented Sep 7, 2016

Copy link
Copy Markdown
Member

There is no 1.5.x branch to cherry-pick onto at the moment.

@tacaswell

tacaswell commented Sep 7, 2016

Copy link
Copy Markdown
Member

I have a running list of things to backport. We probably should give up an re-create the 1.5.x branch :/

@tacaswell
tacaswell merged commit 42b40b8 into matplotlib:master Sep 7, 2016
tacaswell added a commit that referenced this pull request Sep 7, 2016
@tacaswell
Merge pull request #7052 from anntzer/catch-exceptions-in-qt5-draw-pr…
c5cdc1a 
…events-abort

FIX: Uncaught exns are fatal for PyQt5, so catch them.
@tacaswell

tacaswell commented Sep 7, 2016

Copy link
Copy Markdown
Member

backported to v2.x as c5cdc1a

@anntzer
anntzer deleted the catch-exceptions-in-qt5-draw-prevents-abort branch September 7, 2016 17:32
@QuLogic QuLogic added this to the 2.0 (style change major release) milestone Sep 8, 2016
tacaswell added a commit that referenced this pull request Sep 8, 2016
@tacaswell
Merge pull request #7052 from anntzer/catch-exceptions-in-qt5-draw-pr…
81d5a24 
…events-abort

FIX: Uncaught exns are fatal for PyQt5, so catch them.
@tacaswell

tacaswell commented Sep 8, 2016

Copy link
Copy Markdown
Member

backported to v1.5.x as 81d5a24

@QuLogic QuLogic modified the milestones: v1.5.x, 2.0 (style change major release) Sep 9, 2016
@anntzer anntzer mentioned this pull request Sep 12, 2016
Closed
@anntzer anntzer mentioned this pull request Sep 29, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.5.3

Development

Successfully merging this pull request may close these issues.

6 participants

@anntzer @WeatherGod @jenshnielsen @tacaswell @mdboom @QuLogic