Skip to content

Fix #6794: Clipping rectangle needs to be inverted - #7003

Merged
tacaswell merged 2 commits into
matplotlib:v2.xfrom
mdboom:clipping-text
Aug 30, 2016
Merged

tacaswell merged 2 commits into
matplotlib:v2.xfrom
mdboom:clipping-text

Conversation

@mdboom

@mdboom mdboom commented Aug 29, 2016

Copy link
Copy Markdown
Member

No description provided.

@mdboom mdboom added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Aug 29, 2016
@mdboom mdboom added this to the 2.0 (style change major release) milestone Aug 29, 2016
@tacaswell

Copy link
Copy Markdown
Member

@mdboom Can we get a minimal test for this?

@mdboom

mdboom commented Aug 30, 2016

Copy link
Copy Markdown
Member Author

Test added.

@tacaswell
tacaswell merged commit ba83035 into matplotlib:v2.x Aug 30, 2016
fig, (ax1, ax2) = plt.subplots(2)
for x, y in np.random.rand(10, 2):
ax1.text(x, y, "foo", clip_on=True)
ax2.text(x, y, "foo")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have gone with different text for each axes, just to be sure it's clipped to the right place.

LindyBalboa pushed a commit to LindyBalboa/matplotlib that referenced this pull request Sep 2, 2016
Add reference to AxesWidget.active for disabling the selector.

Resolves matplotlib#7003
LindyBalboa pushed a commit to LindyBalboa/matplotlib that referenced this pull request Sep 2, 2016
Add reference to AxesWidget.active for disabling the selector.

Resolves matplotlib#7003
LindyBalboa pushed a commit to LindyBalboa/matplotlib that referenced this pull request Sep 6, 2016
Add reference to AxesWidget.active for disabling the selector.

Resolves matplotlib#7003
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants