Skip to content

DOC: Document verts in scatter - #6963

Merged
NelleV merged 2 commits into
matplotlib:v2.xfrom
tacaswell:doc_scatter_verts
Oct 19, 2016
Merged

NelleV merged 2 commits into
matplotlib:v2.xfrom
tacaswell:doc_scatter_verts

Conversation

@tacaswell

Copy link
Copy Markdown
Member

close #6958

@tacaswell tacaswell added this to the 2.0 (style change major release) milestone Aug 21, 2016
@QuLogic

QuLogic commented Aug 21, 2016

Copy link
Copy Markdown
Member

So I have to ask, in what units? Pixels? Points? Or between 0 and 1 (and scaled by the size)?

@tacaswell tacaswell modified the milestones: 2.0 (style change major release), 2.0.1 (next bug fix release) Aug 22, 2016
@NelleV

NelleV commented Oct 6, 2016

Copy link
Copy Markdown
Member

Hi @tacaswell
If you don't plan on fixing @QuLogic comment any time soon, I suggest we merge this and someone can improve the documentation later.

@tacaswell

Copy link
Copy Markdown
Member Author

thanks for the ping, updated and force-pushed.

Comment thread lib/matplotlib/axes/_axes.py Outdated
**kwargs):
"""
Make a scatter plot of x vs y, where x and y are sequence like objects
"""Make a scatter plot of x vs y, where x and y are sequence like objects

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this should have changed.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure this will break something, though it may be the dedent_interpd that was removed...

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That indeed can break some indentation thing we have going on, but only if we are appending or interpolating this function.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: the documentation build will fail if that is the case.

Comment thread lib/matplotlib/axes/_axes.py Outdated
verts : sequence of (x, y), optional
If `marker` is None, these vertices will be used to
construct the marker. The center of the marker is located
at (0,0) and the size is normalized.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I know, but normalized from what to what? Also, "the size" (as an unqualified term) could be confused with the s parameter.

@NelleV NelleV changed the title DOC: Document verts in scatter [MRG+1] DOC: Document verts in scatter Oct 10, 2016
@tacaswell

Copy link
Copy Markdown
Member Author

At the risk of kicking a hornets nest, re-worded the scatter summary/extended summary.

@efiring and/or @NelleV (sorry, memory failing) did some work to clarify the difference between plot and scatter, where did that end up landing?

@NelleV

NelleV commented Oct 19, 2016

Copy link
Copy Markdown
Member

@tacaswell Excellent questions… I indeed had a pull request adding an element in the notes section about using plot instead of scatter…

@NelleV

NelleV commented Oct 19, 2016

Copy link
Copy Markdown
Member

It is in the see also section: #7096

@NelleV

NelleV commented Oct 19, 2016

Copy link
Copy Markdown
Member

I've got it locally in master, but I can't see it in your file.

@tacaswell

Copy link
Copy Markdown
Member Author

Ah, great. That explains why it was not showing up in my file on this branch (as it was forked before that PR was backported).

@QuLogic

QuLogic commented Oct 19, 2016

Copy link
Copy Markdown
Member

Were you going to rebase, or is this fine?

@tacaswell

Copy link
Copy Markdown
Member Author

It's fine as-is, the changes are non-conflicting.

@NelleV
NelleV merged commit 954d662 into matplotlib:v2.x Oct 19, 2016
@QuLogic QuLogic changed the title [MRG+1] DOC: Document verts in scatter DOC: Document verts in scatter Oct 19, 2016
@tacaswell
tacaswell deleted the doc_scatter_verts branch October 19, 2016 22:32
@QuLogic QuLogic modified the milestones: 2.0.1 (next bug fix release), 2.0 (style change major release) Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants