Skip to content

Value checking the numpoints argument to be a whole number. #6949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pfaion wants to merge 1 commit into from
Closed

Value checking the numpoints argument to be a whole number. #6949

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/matplotlib/legend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,13 @@ def __init__(self, parent, handles, labels,
ncol = 1
self._ncol = ncol

if (

@tacaswell tacaswell Aug 16, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is probably better to do something like if int(n) != n: raise.

Should probably make numpoints a property and do the validation on the way in as well.

This should probably also check that numpoints > 0.

@jenshnielsen jenshnielsen Aug 16, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check for numpoints > 0 is just below

@tacaswell tacaswell Aug 16, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it is 🐑

@tacaswell tacaswell Aug 20, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also see discussion at #6955 (diff)

not isinstance(self.numpoints, int) and
not isinstance(self.numpoints, float) and
not self.numpoints.is_integer()
):
raise ValueError("numpoints must be a whole number; it was %f"
% numpoints)
if self.numpoints <= 0:
raise ValueError("numpoints must be > 0; it was %d" % numpoints)

Expand Down