Repository navigation
Remove POSSIBLY obsolete hist() code for updating dataLim - #6872
Closed
smheidrich wants to merge 3 commits into
Closed
smheidrich wants to merge 3 commits into
smheidrich wants to merge 3 commits into
Conversation
smheidrich
force-pushed
the
remove_obsolete_hist_datalim_update1
branch
from
July 31, 2016 19:54
5c7c380 to
931183f
Compare
Member
|
Nominally 👍 Does this also properly handle all of the stacked/multiple dataset cases? I would feel better about this if we know where this was getting set now. |
The code in question was introduced as a response to Debian bug #503148, but it seems like other parts of the hist function now do its job.
smheidrich
force-pushed
the
remove_obsolete_hist_datalim_update1
branch
from
August 1, 2016 03:48
931183f to
3a43dd2
Compare
Contributor
Author
|
Thanks for the tip, multiple datasets is what kills it. |
Contributor
Author
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

As part of #6669, I'm trying to understand what each piece of code in the
histfunction does.I came across a code segment for setting the axes'
dataLimto the minimum and maximum bin if bins are given as an explicit sequence. It was introduced as a fix for Debian bug #503148 - the previous behaviour was to use the minimum and maximum non-empty bins fordataLim, which obviously went against the user's wishes if bins were given explicitly.But as the tests I introduced in a431582 show, even if the code is removed,
dataLimseems to get set just fine by other parts of thehistfunction nowadays.Can anybody come up with a test case that requires this code fragment to exist? Otherwise I suggest it should be removed, because that would make implementing #6669 slightly easier.