Skip to content

BUG: fix image handling of over, under, and indexed color mapping - #6632

Closed
efiring wants to merge 4 commits into
matplotlib:v2.xfrom
efiring:tacaswell-fix_over_under_images
Closed

efiring wants to merge 4 commits into
matplotlib:v2.xfrom
efiring:tacaswell-fix_over_under_images

Conversation

@efiring

@efiring efiring commented Jun 23, 2016

Copy link
Copy Markdown
Member

This is a commit to handle indexed color mapping on top of @tacaswell's #6581 which fixes image rendering of over and under values.

tacaswell and others added 3 commits June 13, 2016 22:15
Use the same trick for carrying through the masked points to use the
green and blue channels to carry the under/over markers.
…tplotlib into tacaswell-fix_over_under_images
@tacaswell tacaswell added this to the 2.0 (style change major release) milestone Jun 23, 2016
@efiring

efiring commented Jun 23, 2016

Copy link
Copy Markdown
Member Author

I think the merge commit is superfluous; there is probably a simpler and cleaner way to do this, but I wanted to get the tests run so we can move forward if this combination of fixes doesn't break anything.

@tacaswell

Copy link
Copy Markdown
Member

Sorry I have been slow about this. I will (eventually) get your commit on
my branch.

On Thu, Jun 23, 2016 at 1:57 PM Eric Firing notifications@github.com
wrote:

I think the merge commit is superfluous; there is probably a simpler and
cleaner way to do this, but I wanted to get the tests run so we can move
forward if this combination of fixes doesn't break anything.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#6632 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAMMhUcm6F6MiYh4lXf88Xyfa3K3qhVeks5qOsjsgaJpZM4I9EdO
.

@tacaswell

Copy link
Copy Markdown
Member

Closing as the commits from this have been added to the #6581

@tacaswell tacaswell closed this Jun 30, 2016
@efiring
efiring deleted the tacaswell-fix_over_under_images branch October 24, 2021 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants