Skip to content

Subplot spacing#6468

Merged
efiring merged 3 commits into
matplotlib:v2.xfrom
tacaswell:subplot-spacing
May 28, 2016
Merged

Subplot spacing#6468
efiring merged 3 commits into
matplotlib:v2.xfrom
tacaswell:subplot-spacing

Conversation

@tacaswell

Copy link
Copy Markdown
Member

Replaces #6129

@tacaswell tacaswell added this to the 2.0 (style change major release) milestone May 23, 2016
@tacaswell tacaswell added the API: default changes Changes to default behavior label May 23, 2016
@efiring

efiring commented May 28, 2016

Copy link
Copy Markdown
Member

This has a bunch of image failures. Some of them I recognize as trouble-makers from earlier style changes. I'm not sure whether the best solution is just replacing the images.

@tacaswell

Copy link
Copy Markdown
Member Author

Digging into why these are failing is on my list of things to do today.

On Sat, May 28, 2016, 14:03 Eric Firing notifications@github.com wrote:

This has a bunch of image failures. Some of them I recognize as
trouble-makers from earlier style changes. I'm not sure whether the best
solution is just replacing the images.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#6468 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAMMhcBesWznV5Un9AA24LbBtbk09OAWks5qGINmgaJpZM4IkzRk
.

@tacaswell

Copy link
Copy Markdown
Member Author

3 of the tests that explicitly use the new defaults and 4 of them are the pgf tests.

I think that until we tag 2.0, the image comparison should just knownfail any non-'classic' style test.

@tacaswell

Copy link
Copy Markdown
Member Author

Assuming this passes it should be ready to go. The other default change PRs should probably be rebased to also side-step some of this pain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API: default changes Changes to default behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants