Skip to content

mpl_toolkits: Fiducials/Landmark markers - #6341

Closed
JGoutin wants to merge 4 commits into
matplotlib:masterfrom
JGoutin:MplToolkitsFiducials
Closed

JGoutin wants to merge 4 commits into
matplotlib:masterfrom
JGoutin:MplToolkitsFiducials

Conversation

@JGoutin

@JGoutin JGoutin commented Apr 27, 2016

Copy link
Copy Markdown
Contributor

I created a toolkit for use numbered fiducial "cross" markers with Matplotlib interactively.

This is mainly useful for image processing, but may also help for other cases.

I propose it for adding in mpl_toolkits.

@tacaswell tacaswell added this to the 2.1 (next point release) milestone Apr 27, 2016
@tacaswell

Copy link
Copy Markdown
Member

Nifty (attn @licode this is probably useful at BNL).

This would probably do better as a stand alone repo under the mpl organization (which decouples you from our glacial release cycle 😉 )

This might also fit in @joferkington 's mpldatacursor?

Have only skimmed this, but might have some interaction with @blink1073 's widget work?

@JGoutin

JGoutin commented Apr 27, 2016

Copy link
Copy Markdown
Contributor Author

Your release cycle don't bother me. I didn't planed to update this really intensively 😉.

I not tested interactions with packages other than MPL. There is maybe some possible conflicts on keys shortcuts.

@licode

licode commented Apr 27, 2016

Copy link
Copy Markdown

I think so. Good to know this feature.

@blink1073

Copy link
Copy Markdown
Member

@tacaswell, yeah, these could certainly overlap (especially for the advanced marker types), if I ever get around to finishing #5786.

@anntzer

anntzer commented Aug 31, 2017

Copy link
Copy Markdown
Contributor

I think this kind of feature belongs more to a third-party package (there is some overlap with mpldatacursor and mplcursors -- disclaimer, I wrote the later).
A dependency, even optional, on skimage is a non-starter IMO.
This would also need some testing.

Unless someone objects, I will close the PR.

@JGoutin

JGoutin commented Aug 31, 2017

Copy link
Copy Markdown
Contributor Author

You can close this PR. I see not objects.

Note: I'll not make a third party package for this. If someone is interested by getting this, no problems, I can eventually help to add this to another package. If not, I'll delete my forked repository when this PR will be closed.

@dstansby dstansby modified the milestones: 2.1 (next point release), 2.2 (next next feature release) Sep 17, 2017
@anntzer

anntzer commented Mar 17, 2018

Copy link
Copy Markdown
Contributor

Closing based on lack of activity or objections against closing...

@anntzer anntzer closed this Mar 17, 2018
@JGoutin
JGoutin deleted the MplToolkitsFiducials branch March 17, 2018 17:11
@story645 story645 removed this from the future releases milestone Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants