Repository navigation
Conversation
| 'straight': a simplified }, with the 7 control points p0...p6 | ||
| simply linked with straight lines. | ||
|
|
||
| Details of the basic design: |
Member
There was a problem hiding this comment.
Can you put two colons at the end of this line so the ASCII art gets rendered correctly in the docs.
Member
|
@afvincent is this still WIP? |
Contributor
Author
|
@tacaswell TBH, I am not currently working actively on it at the moment. So this PR has kind of stalled. I am equally fine tagging it for a release in a far future or even simply close it if your point is tidying the open PRs. |
Contributor
Author
|
Closing this PR as I did not find time to work on it at all since my last comment and unfortunately this situation is unlikely to evolve. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[2017-03-08] Edit: Removing for the
need_reviewflag for the moment as the code is actually not totally finished. I would qualify the PR of “WiP”, eventhough I am not currently actively working on it… This PR (or a “rebirth” version) might be part of the arrow plotting overhaul that @dstansby is willing to initiate :).Generalities
PR that was mentioned in #6112 , about adding a new arrowstyle with curly brackets for head or tail. It is mainly targeted for use with
FancyArrowPatch(as the other arrowstyles), with the style names "}-" forBraceA, "-{" forBraceB, and "}-{" forBraceAB. I implemented it for myself as I missed a few times such a feature and had to use Inkscape to add this kind of annotation to my figures.Since #6112 , I finally got working what I really wanted: arrowstyle "<-{", aka
CurveABraceB. It seems to do what I want (an arrow with a normal head and a brace at the other side) but unfortunately, I have difficulties to understand howsuper()works (especially with multpile inheritance), so the review of__init__inCurveABraceBis liketo to end up with changes. (See the last ~100 lines of the commit)Furthermore, supplementary variations with straight braces are accessible by initializing the instance with one or two args to "straight". However, I didn't set dedicated stylenames for these versions, as the list of stylenames is already slightly long.
Here are some examples of what is currently achievable with these new arrowstyles:

Interrogations (some details are in the commit comments)
The computation of the brace (with lines and quadratic Bezier curves) is done in the method
_get_brace. I tried to explain the construction of the brace as clearly as I could: the docstring may appear a bit long... Besides , I internally use a parameterpadthat one may want to expose as an argument.I have used a @staticmethod decorator for
_get_brace, because I may implement a new patchBracePatchthat would also use it. For example, such a patch might be used to annotate a range of data. Unfortunately, I don't know when I will have time to try this.It is planned to update the relevant unit test once review will have been done.
Appendix
The code used to generate to previous figure, adapted from the documentation: