Repository navigation
Conversation
added 14 commits
January 2, 2016 07:48
Member
Author
|
Ready for review. |
Member
Author
|
I've still got more comments to write, including the |
added 10 commits
January 3, 2016 05:39
Member
Author
|
I decided to do all the tools at once (and add the paint tool), because it will better inform what the base class should look like. I'll also add a UAT notebook. |
Member
Author
|
@pelson @tacaswell, I propose the following: |
Member
Author
|
Closing in favor of implemented the Painter widget only in #7411. I bit off more than I can chew with this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

See discussion in #5782.
Implements
RectangleTool,EllipseTool, andLineToolto flesh out the base class requirements. I'll save Lasso, Polygon and Span for subsequent PRs.