Repository navigation
No edges on filled things by default #5596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
62df86d
f88114c
de7bc93
5bb29e0
84496fa
e8d998f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -325,7 +325,7 @@ def _makefill(self, x, y, kw, kwargs): | |
| seg = mpatches.Polygon(np.hstack((x[:, np.newaxis], | ||
| y[:, np.newaxis])), | ||
| facecolor=facecolor, | ||
| fill=True, | ||
| fill=kwargs.get('fill', True), | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What prompted this change?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. histogram steps (for one) go through this path, but sometimes pass |
||
| closed=kw['closed']) | ||
| self.set_patchprops(seg, **kwargs) | ||
| return seg | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -497,3 +497,5 @@ animation.convert_path: convert # Path to ImageMagick's convert binary. | |
| # is also the name of a system tool. | ||
| animation.convert_args: | ||
| animation.html: none | ||
|
|
||
| _internal.classic_mode: True | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is a "no newline at end of file" marker here. I've never seen that before. Doesn't PEP8 require a newline at end of file?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry, missed this comment as I was pressing merge.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. PEP8 doesn't apply as this isn't a Python file ;) But yes, we can go in and add the newline next time we touch this file. |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this pull from
colorinstead? That way, there is no visible edge.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'e' here stands for 'errorbar' not 'edge'