Skip to content

ENH: errorbar color cycle clean up - #5593

Merged
jenshnielsen merged 7 commits into
matplotlib:masterfrom
tacaswell:fix_errorbar_cycleing
May 30, 2016
Merged

jenshnielsen merged 7 commits into
matplotlib:masterfrom
tacaswell:fix_errorbar_cycleing

Conversation

@tacaswell

Copy link
Copy Markdown
Member

@mdboom This is what I was talking about on the phone call.

@tacaswell tacaswell changed the title WIP WIP: errorbar color cycle clean up Dec 1, 2015
@tacaswell tacaswell added this to the unassigned milestone Dec 1, 2015
@mdboom

mdboom commented Dec 1, 2015

Copy link
Copy Markdown
Member

Great -- this definitely addresses part of #5584 in a better way. Should we also remove the use of Axes.plot in favor of Axes.line2d while we're in there?

Instead of using calls to `plt.plot`
@tacaswell
tacaswell force-pushed the fix_errorbar_cycleing branch from ddde346 to c8a365a Compare May 13, 2016 02:32
@tacaswell tacaswell modified the milestones: 2.1 (next point release), unassigned May 13, 2016
tacaswell added 4 commits May 12, 2016 22:58
Need 3 internal style dictionaries:

  - eb_lines_style : used for the line collections
  - eb_cap_style : base style to be used for the bar 'caps'
  - plot_line_style : used from the 'main' line
@tacaswell

Copy link
Copy Markdown
Member Author

The decision to consult the prop-cycle still needs to be fixed.

attn @WeatherGod

@tacaswell

Copy link
Copy Markdown
Member Author

and is this a 2.0 or 2.1 tagged issue?

@tacaswell tacaswell modified the milestones: 2.0 (style change major release), 2.1 (next point release) May 13, 2016
@tacaswell tacaswell closed this May 23, 2016
@tacaswell tacaswell reopened this May 23, 2016
@jenshnielsen jenshnielsen self-assigned this May 23, 2016
@tacaswell tacaswell added the API: default changes Changes to default behavior label May 23, 2016
Comment thread lib/matplotlib/axes/_axes.py Outdated
uplims = np.asarray(uplims, bool)
if plot_line:
l0 = mlines.Line2D(x, y, **plot_line_style)
self.add_line(l0)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick this variable name looks a bit to close to 10 I first read the line as self.add_line(10)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, will fix that.

@jenshnielsen

Copy link
Copy Markdown
Member

👍 @tacaswell Does this need more work ([WIP] in the title) of is it ready?

@tacaswell tacaswell changed the title WIP: errorbar color cycle clean up ENH: errorbar color cycle clean up May 25, 2016
'l0' (el-zero) looks too much like 10 (ten) to be used as a variable
name.
@tacaswell
tacaswell force-pushed the fix_errorbar_cycleing branch from 751d108 to 2338e2e Compare May 28, 2016 20:18
@tacaswell

Copy link
Copy Markdown
Member Author

This should be ready to go.

@jenshnielsen
jenshnielsen merged commit 597d2ef into matplotlib:master May 30, 2016
jenshnielsen added a commit to jenshnielsen/matplotlib that referenced this pull request May 30, 2016
@jenshnielsen

Copy link
Copy Markdown
Member

Back port to 2.x as acfab37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API: default changes Changes to default behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants