Skip to content

Don't draw text when it's completely clipped away - #5432

Merged
jenshnielsen merged 2 commits into
matplotlib:masterfrom
mdboom:fix-segfault-in-text-drawing
Nov 8, 2015
Merged

jenshnielsen merged 2 commits into
matplotlib:masterfrom
mdboom:fix-segfault-in-text-drawing

Conversation

@mdboom

@mdboom mdboom commented Nov 7, 2015

Copy link
Copy Markdown
Member

Fix #5429.

@mdboom mdboom added this to the proposed next point release (2.1) milestone Nov 7, 2015
@tacaswell tacaswell modified the milestones: next bug fix release (2.0.1), proposed next point release (2.1) Nov 7, 2015
@tacaswell

Copy link
Copy Markdown
Member

This needs to get backported to 2.0.x as the faster text rendering was backported there as well.

@mdboom mdboom modified the milestones: next major release (2.0), next bug fix release (2.0.1) Nov 7, 2015
@jenshnielsen

Copy link
Copy Markdown
Member

Thanks unfortunately there seems to be something wrong

boxarrow_test_image

@jenshnielsen

Copy link
Copy Markdown
Member

I think that is due to the change from

(yi - (y - image.dim(0))

to

(yi - y) - image.dim(0))

@mdboom

mdboom commented Nov 8, 2015

Copy link
Copy Markdown
Member Author

Updated per @jenshnielsen

jenshnielsen added a commit that referenced this pull request Nov 8, 2015
Don't draw text when it's completely clipped away
@jenshnielsen
jenshnielsen merged commit 781540e into matplotlib:master Nov 8, 2015
jenshnielsen added a commit to jenshnielsen/matplotlib that referenced this pull request Nov 8, 2015
…rawing

Don't draw text when it's completely clipped away
jenshnielsen added a commit that referenced this pull request Nov 8, 2015
Merge pull request #5432 from mdboom/fix-segfault-in-text-drawing
@jenshnielsen

Copy link
Copy Markdown
Member

backported as 5129136

@mdboom
mdboom deleted the fix-segfault-in-text-drawing branch November 10, 2015 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants