Repository navigation
New Colormaps to docs - #5284
Merged
Merged
Conversation
Also partly pep8 and make the figure a bit smaller
Pep8 and tweak size
Re: @stefanv's comment
Refactor to reduce duplication
Member
|
Looks like the docs build doesn't work correctly
|
Member
|
Otherwise Looks good to me. Thanks for finishing this @mdboom |
Member
There was a problem hiding this comment.
"for which they have been created."
Member
|
Everything else looks good to me once Travis passes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This supercedes and includes #4965, since I'd like to get this in for 1.5.0 and @jenshnielsen noted he may be busy this week.
It addresses the remaining comments in #4965, namely to create a new category for the new perceptually uniform colormaps, and some prose improvements in the text.