Skip to content

TST: fix PermissionError on Windows #5278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cgohlke wants to merge 2 commits into from
Closed

TST: fix PermissionError on Windows #5278

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d313ca
TST: fix PermissionError on Windows
cgohlke Oct 20, 2015
70c36ae
TST: on Windows, manually remove temporary file
cgohlke Oct 22, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/matplotlib/tests/test_font_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
from nose.tools import assert_equal
from matplotlib.externals import six

import sys
import os
import tempfile
import warnings
Expand All @@ -24,8 +25,14 @@ def test_font_priority():

def test_json_serialization():
with tempfile.NamedTemporaryFile() as temp:
if sys.platform == 'win32':
# on Windows, an open NamedTemporaryFile can not be used
# to open the file a second time
temp.close()
json_dump(fontManager, temp.name)
copy = json_load(temp.name)
if sys.platform == 'win32':
Copy link
Member

@mdboom mdboom Oct 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in a try/finally so it always runs.

Copy link
Member

@WeatherGod WeatherGod Oct 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sigh... we are making this overly complicated.

try:
    temp = tempfile.NamedTemporaryFile(delete=False)
    temp.close()
    json_dump(fontManager, temp.name)
    copy = json_load(temp.name)
finally:
    if os.path.exists(temp.name):
        os.remove(temp.name)

os.remove(temp.name)
with warnings.catch_warnings():
warnings.filterwarnings('ignore', 'findfont: Font family.*not found')
for prop in ({'family': 'STIXGeneral'},
Expand Down