Repository navigation
FIX: remove incorrect error checking - #5187
Merged
Merged
Conversation
Currently fails with qt5
Contributor
|
this indeed fix teh errors with the unittest raising that exception, but now that it passes, other errors came out: |
Member
Author
|
That looks like there is a cross between qt4 vs qt5 ... |
jenshnielsen
added a commit
that referenced
this pull request
Oct 5, 2015
FIX: remove incorrect error checking
Member
|
I can reproduce that issue with both qt 4 and 5 installed. It looks like something has gotten crossed in the refactoring. |
Member
Author
|
@jenshnielsen What backend is this with? |
Member
|
That was the qt4 tests in the test suite |
Member
Author
|
@jenshnielsen Took me a while, but I got there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently fails with qt5