Repository navigation
Bugfix for TriAnalyzer mismatched indexes - #5065
Merged
WeatherGod merged 1 commit intoSep 14, 2015
Merged
WeatherGod merged 1 commit into
WeatherGod merged 1 commit into
Conversation
WeatherGod
added a commit
that referenced
this pull request
Sep 14, 2015
…_indexes Bugfix for TriAnalyzer mismatched indexes
Member
|
Thanks @ianthomas23! Great to get this in for 1.5! |
Contributor
|
Thanks @ianthomas23 for the fix. (Sorry for being late on this one, I have been trying to compile again from master under windows with no success so far). However I have noticed this line in Should be |
Member
Author
|
@GBillotey: OK, I have written another PR to cover the second occurrence of the bug that you've found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bugfix for issue #4999.
It follows a tightening up in numpy 1.10 when indexing one array with a second boolean array which is smaller, such as
Here
index_arrayis shorter thanx. Prior to numpy 1.10 this was acceptable, withindex_arraypadded out withFalsevalues. In numpy 1.10 it issues aVisibleDeprecationWarning.The problem occurs in
TriAnalyzerfor aTriangulationthat contains points that are not referenced by any triangles, which can occur if triangles are masked out. The solution is to make sure the boolean array is of the correct size, which is easily accomplished in this case using theminlengthkwarg which was added tonumpy.bincountin version 1.6.I have not added an explicit test as the existing
test_triangulation.test_tritoolsalready finds the bug.Thanks to @WeatherGod for reporting the problem.