Skip to content

Rasterize colorbar when it has many colors; closes #4480 - #4481

Merged
WeatherGod merged 1 commit into
matplotlib:masterfrom
efiring:rasterize_colorbar
Jun 8, 2015
Merged

WeatherGod merged 1 commit into
matplotlib:masterfrom
efiring:rasterize_colorbar

Conversation

@efiring

@efiring efiring commented May 27, 2015

Copy link
Copy Markdown
Member

I think this is the simplest possible way to reduce the number of complaints about the appearance of the colorbar as rendered from vector files. It could be made more complicated by using an rcParam for the threshold, and/or by adding a kwarg, but I'm not convinced that either of these would be worthwhile.

@efiring

efiring commented May 27, 2015

Copy link
Copy Markdown
Member Author

Travis failures are unrelated.

@tacaswell

Copy link
Copy Markdown
Member

How about making the threshold a public attribute of Colorbar? If we hard code this someone will complain.

@tacaswell tacaswell added this to the next point release milestone May 28, 2015
@efiring

efiring commented May 28, 2015

Copy link
Copy Markdown
Member Author

Yes, I know... It sounds like you are talking about making it a class attribute for now, in anticipation of all instance configuration variables ending up declared at the class level as Configurables or some such. Correct?

@tacaswell

Copy link
Copy Markdown
Member

I was thinking as an instance level attribute, but class level makes more sense.

@efiring

efiring commented Jun 7, 2015

Copy link
Copy Markdown
Member Author

@tacaswell If this looks OK, I can add a what's new entry. @WeatherGod, comments?

@tacaswell

Copy link
Copy Markdown
Member

👍 from me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants