Suggest non-existing default filename (Implement #3608) - #4221

Can you also add a test? I would suggest something like

import tempfile
@cleanup
def test_filename():
    test_dir = tempfile.mkdtemp()
    rcParams['saving.directory'] = test_dir
    target_name = os.path.join(test_dir, 'figure_1.png')
    target_name2 = os.path.join(test_dir, 'figure_1-1.png')
    fig = plt.figure()
    fn = fig.get_default_filename()
    assert_equal(fn, target_name)
    fig.save_fig(fn)
    fn2 = fig.get_default_filename()
    assert_equal(fn2, target_name2)

Done. Should the created temp directories/files be cleaned up after the test? From Python docs: "The user of mkdtemp() is responsible for deleting the temporary directory and its contents when done with it."

Yes please to cleaning up the temp directory.

On Mon, Mar 16, 2015, 05:13 Umair Idris notifications@github.com wrote:

Done. Should the created temp directoies/files be cleaned up after the
test? From Python docs: "The user of mkdtemp() is responsible for deleting
the temporary directory and its contents when done with it."

—
Reply to this email directly or view it on GitHub
#4221 (comment)
.

Yes please to cleaning up the temp directory.

Done.

Thanks!