Skip to content

fix find_output_cell for IPython >= 3.0 [backport to 1.4.x] #4002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tacaswell merged 2 commits into from
Jan 15, 2015
Merged

fix find_output_cell for IPython >= 3.0 [backport to 1.4.x] #4002

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b933cfd
fix find_output_cell for IPython >= 3.0
minrk Jan 14, 2015
654afd2
log failure to find cell/output
minrk Jan 14, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions lib/matplotlib/backends/web_backend/nbagg_mpl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@ mpl.mpl_figure_comm = function(comm, msg) {

fig.parent_element = element.get(0);
fig.cell_info = mpl.find_output_cell("<div id='" + id + "'></div>");
if (!fig.cell_info) {
console.error("Failed to find cell for figure", id, fig);
return;
}

var output_index = fig.cell_info[2]
var cell = fig.cell_info[0];
Expand Down Expand Up @@ -160,12 +164,15 @@ mpl.find_output_cell = function(html_output) {
var ncells = cells.length;
for (var i=0; i<ncells; i++) {
var cell = cells[i];
if (cell.cell_type == 'code'){
if (cell.cell_type === 'code'){
for (var j=0; j<cell.output_area.outputs.length; j++) {
var data = cell.output_area.outputs[j];
if (cell.output_area.outputs[j]['text/html'] == html_output) {
var output = cell.output_area.outputs[j];
return [cell, output, j];
if (data.data) {
// IPython >= 3 moved mimebundle to data attribute of output
data = data.data;
}
if (data['text/html'] == html_output) {
return [cell, data, j];
}
}
}
Expand Down