-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
Allow Artists to show pixel data in cursor display #3989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
34854db
Add the ability for artists to display zdata in cursor
7e0d1ca
PEP8 fix
97640da
Another Pep8 fix
139d820
Pep8: fix trailing whitespace
17e4211
Style update
fcda62b
Standardize the hit test and zordering
8ea9504
Fix the artist sorting behaviour
02456b8
Fix syntax error
641304c
Specify hitlist on axes instead of figure
3f20d3a
Put get_zdata on the correct class
5850150
Ignore the axes patch
88b56be
Create new function to format zdata
aece695
Clean up string formatting
07745c8
Add a whats new blurb.
7626394
Add a test for image cursor data
7b0b6b1
Rename to get_pixel_data and return raw data
f5ff73f
Update the whats new
ea565c6
Fix name of method
1429206
Fix default pixel data and handle no pixel data
e62b0e3
Update test for new method name
34b4df4
Simplify transform
8f266a1
Update display
70983ff
Simplify format_pixel_data
cd0e52b
Update name to cursor_data
8ce3a6f
Move artist sort to within if block
bac8dff
Fix method name in cursor_test
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| Allow Artists to Display Pixel Data in Cursor | ||
| --------------------------------------------- | ||
|
|
||
| Adds `get_pixel_data` and `format_pixel_data` methods to artists | ||
| which can be used to add zdata to the cursor display | ||
| in the status bar. Also adds an implementation for Images. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something seems odd about checking if
artistsis empty after sorting the list. I know (providedartistsis a list) it won't error out, but still seems to me that the sort should go ahead and move within theifblock.Also, +1 for removing ye olden style DSU in favor of
sort(key=).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call, done.