Repository navigation
insert deprecation warning for set_graylevel - #3812
Merged
Merged
Conversation
Member
|
@mdboom Do we add an entry to api_changes when we slate stuff for removal? If not, we probably should. |
tacaswell
added
status: needs review
API: changes
Member
|
👍 On this modulo documentation from me |
Member
|
Yes -- I think we should an entry into api_changes.rst for this, under a new heading "Changes in 1.5.x". Thanks for doing this, @jbmohler. Removing unused code is always a good thing. |
Contributor
Author
|
yep, the programming days I'm happiest is when my net lines of code is negative! |
Member
|
Can you put it in it's own file in the api_changes folder? This is a scheme to reduce doc-conflict caused rebases. |
jbmohler
force-pushed
the
deprecate_graylevel
branch
from
November 19, 2014 09:16
0e747c8 to
d1fd40c
Compare
Contributor
Author
|
@tacaswell that's a good idea. I took the opportunity to clarify my grammar as well. |
tacaswell
added a commit
that referenced
this pull request
Nov 21, 2014
API : insert deprecation warning for set_graylevel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pursuant to comments in #3683 , this is a deprecation warning for set_graylevel in the backends.