Repository navigation
Fixes TypeError when installing without freetype - #3414
Conversation
There was a problem hiding this comment.
should this be if version is not None and ... ?
There was a problem hiding this comment.
No, this is what I meant. The next line gets version another way.
There was a problem hiding this comment.
It is not obvious to me that what ever makes the call fail should be handled the same as the case this if statement is supposed to catch (where the call succeeds (returns 0), but does not work).
There was a problem hiding this comment.
Original pull request: #3363.
I think handling an invalid return value (the text "No such file or directory...") the same as an error code (status != 0) from freetype-config makes sense. The original PR really works around the fact that freetype-config exits with 0 on error here.
|
@pelson Can you take a look at this? |
|
and @matthew-brett |
|
I ran into this exact issue moments ago. Applied the given pull request to the current |
|
👍 - thanks for this. |
Fixes TypeError when installing without freetype
When
freetype-configis missing, setup.py crashes with TypeError. This fixes it and allows the "required packages" info to be printed.Log of the error installing 1.4.0: