Skip to content

[DOC] Add Apache 2.0 license for Turbo colormap (#30651) - #32548

Closed
krish57-bit wants to merge 1 commit into
matplotlib:mainfrom
krish57-bit:fix/turbo-colormap-license
Closed

krish57-bit wants to merge 1 commit into
matplotlib:mainfrom
krish57-bit:fix/turbo-colormap-license

Conversation

@krish57-bit

Copy link
Copy Markdown

PR summary

The Turbo colormap (contributed in gh-15275 by Anton Mikhailov, Google LLC) is licensed under Apache-2.0. The license page currently only references the pull request with no copyright text or license file included.

This PR adds LICENSE/LICENSE_TURBO with the full Apache License 2.0 text and copyright notice (Copyright 2019 Google LLC), and updates doc/project/license.rst to display it via literalinclude — consistent with how ColorBrewer, Solarized, and Yorick licenses are presented.

Closes #30651

AI Disclosure

This pull request includes code written with the assistance of AI. The code has not yet been reviewed by a human.

The Turbo colormap (contributed in matplotlibgh-15275 by Anton Mikhailov, Google
LLC) is licensed under Apache-2.0. The license page listed only a note
referencing the pull request, with no copyright text or license file.

This adds LICENSE/LICENSE_TURBO containing the copyright notice and full
Apache License 2.0 text (copyright 2019 Google LLC), and updates
doc/project/license.rst to display it via ``literalinclude``, consistent
with how all other colormap licenses (ColorBrewer, Solarized, Yorick)
are presented.

Fixes matplotlib#30651
@github-actions

Copy link
Copy Markdown

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks. We also ask that you please finish addressing any review comments on this PR and wait for it to be merged (or closed) before opening a new one, as it can be a valuable learning experience to go through the review process.

You can also join us on discourse chat for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide.
Please let us know if (and how) you use AI, it will help us give you better feedback on your PR.

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@iccir

iccir commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Marking as auto close:

  1. This PR appears to be AI generated as "The code has not yet been reviewed by a human." is in the PR body.
  2. Per this comment in #30651, colormap was added directly by the original author. The linked issue was already closed by Added Turbo License doc #30900.

@iccir iccir added the status: autoclose candidate PRs that are not yet ready for review and may be automatically closed in two weeks label Oct 28, 2026
@github-actions

Copy link
Copy Markdown

⏰ This pull request might be automatically closed in two weeks from now.

Thank you for your contribution to Matplotlib and for the effort you have put into this PR. This pull request does not yet meet the quality and clarity standards needed for an effective review. Project maintainers have limited time for code reviews, and our goal is to prioritize well-prepared contributions to keep Matplotlib maintainable.

Matplotlib maintainers cannot provide one-to-one guidance on this PR. However, if you ask focused, well-researched questions, a community member may be willing to help. 💬

To increase the chance of a productive review:

As the author, you are responsible for driving this PR, which entails doing necessary background research as well as presenting its context and your thought process. If you are a new contributor, or do not know how to fulfill these requirements, we recommend that you familiarize yourself with Matplotlib's development conventions or engage with the community via our Discourse or one of our meetings before submitting code.

If you substantially improve this PR within two weeks, leave a comment and a team member may remove the status: autoclose candidate label and the PR stays open. Cosmetic changes or incomplete fixes will not be sufficient. Maintainers will assess improvements on their own schedule. Please do not ping (@) maintainers.

@jklymak jklymak closed this Oct 28, 2026
@jklymak

jklymak commented Oct 28, 2026

Copy link
Copy Markdown
Member

Let's just close because this was already discussed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

first-contribution status: autoclose candidate PRs that are not yet ready for review and may be automatically closed in two weeks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MNT]: Add copyright information for google's "turbo" colormap?

3 participants