Repository navigation
Conversation
…pybind-mplarray # Conflicts: # src/_image_wrapper.cpp
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Important
This PR depends on #32532 and will appear larger than it really is until #32532 is merged. To view the actual changes in this PR, compare pybind-mplarray-initial → pybind-mplarray.
DRAFT
This PR converts the remainder of our
py::arrayusage tompl::array, as appropriate. This is currently a draft so I can run CI.Naming Conventions
This PR attempts to make variable names and class member names consistent. We previously assigned "no suffix" to the pybind11
unchecked_referenceproxy objects. In this PR, I assigned "no suffix" tompl::array_view(which should be preferred for fast access).mpl::defer<FooArray>orstd::optional<mpl::defer<…>>foo_objFooArrayfoo_arrFooArray::ViewTypefoofoo_arr.data()foo_dataTri Changes
(Talk about the change from empty tuples to
None.)AI Disclosure
PR quality check